Skip to content

Fix precision of audinterface.utils.to_timedelta() #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jul 27, 2023

Closes #134

Blocked by #135

When providing the time already as pd.Timedelta we have to ensure that we do not loose precision (compare #113). The easiest way to achieve this is to check if the type is already pd.Timedelta and not convert in that case.

@hagenw hagenw marked this pull request as draft July 27, 2023 14:21
@hagenw hagenw force-pushed the fix-to-timedelta branch from 6f8ceab to 12d3171 Compare July 28, 2023 09:25
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #137 (60c85fb) into main (b88b3d9) will not change coverage.
The diff coverage is 100.0%.

Files Changed Coverage Δ
audinterface/core/utils.py 100.0% <100.0%> (ø)

@hagenw hagenw changed the title Fix audinterface.to_timedelta() precision when Timedelta values are given Fix precision of audinterface.utils.to_timedelta() Jul 28, 2023
@hagenw hagenw marked this pull request as ready for review July 28, 2023 09:46
@hagenw hagenw merged commit 2620d4d into main Jul 28, 2023
@hagenw hagenw deleted the fix-to-timedelta branch July 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audinterface.utils.signal_index() wrongly rounds time values
1 participant