Skip to content

Fix order of start/end values in audinterface.Segment #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jul 27, 2023

Closes #135

In audinterace.Segment the process functions return an index, which in most cases is generated at the end of the involved process function. Usually, this involves requesting starts and ends values from previous processing steps. In some cases these were wrongly done by index.levels instead of index.get_level_values().

This expands the tests and fixes the underlying issue.

@hagenw hagenw marked this pull request as draft July 27, 2023 14:21
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #136 (ac7638f) into main (e615890) will not change coverage.
The diff coverage is 100.0%.

Files Changed Coverage Δ
audinterface/core/segment.py 100.0% <100.0%> (ø)

@hagenw hagenw marked this pull request as ready for review July 28, 2023 09:08
@hagenw hagenw changed the title Fix index order of audinterface.Segment when files are involved Fix order of returned start/end values in audinterface.Segment Jul 28, 2023
@hagenw hagenw changed the title Fix order of returned start/end values in audinterface.Segment Fix order of start/end values in audinterface.Segment Jul 28, 2023
@hagenw hagenw merged commit b88b3d9 into main Jul 28, 2023
@hagenw hagenw deleted the fix-segment-order branch July 28, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audinterface.Segment reorders ends entries when file argument given to process_signal
1 participant