Skip to content

Fix stream max_by_key and min_by_key #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 19, 2019
Merged

Fix stream max_by_key and min_by_key #559

merged 6 commits into from
Nov 19, 2019

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Nov 19, 2019 •
edited
Loading

fix: #558

@k-nasa k-nasa marked this pull request as ready for review November 19, 2019 15:46
yoshuawuyts
yoshuawuyts approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks heaps!

@yoshuawuyts yoshuawuyts merged commit f24b3a4 into async-rs:master Nov 19, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Nov 19, 2019
Closed
@k-nasa k-nasa deleted the fix_max_by_key branch November 20, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_by_key is wrong
2 participants
@k-nasa @yoshuawuyts