Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
task::blocking
totask::spawn_blocking
, and changes the input type fromimpl Future
toimpl FnOnce
so that it becomes clear that this function is for non-async code only.We received public feedback on the signature, and @stjepang and I spoke privately about the method name and agreed that it was indeed confusing with
block_on
also being a thing.Because this API has changed, it means that #290 will no longer be able to be called inside
task::blocking
, but instead tasks should rely onthread::yield_now
instead. This overall feels like a positive to me.Thanks!