Expose pin project #258
Closed
Expose pin project #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
|
I don't think re-exports will work at this time because current pin-project requires that the crate name is exactly I know how to make this work well :), but that means blessing async-std, so I don't know if I really want to do it. |
|
I would also hold back on this, to avoid accidental blessing. |
|
Closing because we can't merge this now either way. I'm sympathetic to what's been said in this thread. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-exports
pin-projecttraits from our unstablepinsubmodule. We should eventually pair this up with some good docs on what pinning is, why pin projection is useful, and how to do it using these attributes.From internal discussions we've been considering adopting
pin-projectto remove our use ofunsafefrom our pin projections. It'd be great if we could write down our experiences porting from unsafe projections to pin-project, and use that to guide others to do the same. Thanks!Related #203
cc/ @taiki-e
Screenshot