Implement simple work stealing #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Sep 17, 2019
yoshuawuyts
reviewed
Sep 17, 2019
| pub(crate) struct Pool { | ||
| pub injector: Injector<task::Runnable>, | ||
| pub stealers: Vec<Stealer<task::Runnable>>, | ||
| pub sleepers: Sleepers, |
There was a problem hiding this comment.
These fields should probably be marked pub(crate).
There was a problem hiding this comment.
We can always do this later.
yoshuawuyts
approved these changes
Sep 17, 2019
Co-Authored-By: Yoshua Wuyts <[email protected]>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 17, 2019
205: Implement simple work stealing r=yoshuawuyts a=stjepang This is our first version of a work-stealing scheduler. We won't stop here, there is still lots of room for improvement. Co-authored-by: Stjepan Glavina <[email protected]>
Build succeeded
|
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our first version of a work-stealing scheduler. We won't stop here, there is still lots of room for improvement.