Skip to content

Bugfix/non ascii filenames #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2023
Merged

Bugfix/non ascii filenames #58

merged 3 commits into from
Jul 7, 2023

Conversation

murilopolese
Copy link
Contributor

Clean non-ascii characters on filenames the same way we do with the file content.

@murilopolese murilopolese requested a review from ubidefeo July 6, 2023 14:58
ubidefeo
ubidefeo approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubidefeo ubidefeo requested a review from kittaakos July 7, 2023 07:32
kittaakos
kittaakos reviewed Jul 7, 2023
View reviewed changes
kittaakos
kittaakos reviewed Jul 7, 2023
View reviewed changes
ubidefeo
ubidefeo approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittaakos requested a fix and it's now double approved

@ubidefeo ubidefeo merged commit 9dedd05 into main Jul 7, 2023
@ubidefeo ubidefeo deleted the bugfix/non-ascii-filenames branch July 7, 2023 11:55
@per1234 per1234 added the bug Something isn't working label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos left review comments

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murilopolese @kittaakos @ubidefeo @per1234