Skip to content

Bugfix/startup selecting folder #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2024
Merged

Bugfix/startup selecting folder #117

merged 4 commits into from
Apr 23, 2024

Conversation

murilopolese
Copy link
Contributor

Problem

  • First time opening the app the UI would always get stuck after selecting the local folder
  • When opening two instances, it would be like opening the app for the first time so it would also get stuck

Solution

Make sure there is a state.diskNavigationRoot set before triggering a refresh-files event

Extra

  • Created a component for the overlay messages to cleanup main.js
  • Re-enabled Chrome DevTools on production builds

@murilopolese murilopolese requested a review from ubidefeo April 23, 2024 08:21
ubidefeo
ubidefeo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@murilopolese murilopolese merged commit 180cb19 into development Apr 23, 2024
1 check passed
@murilopolese murilopolese deleted the bugfix/startup-selecting-folder branch April 23, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murilopolese @ubidefeo