Skip to content

Bugfix/saving #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2024
Merged

Bugfix/saving #110

merged 3 commits into from
Apr 16, 2024

Conversation

murilopolese
Copy link
Contributor

I forgot to call getPrompt before calling fileExists.

@murilopolese murilopolese requested a review from ubidefeo April 16, 2024 08:26
ubidefeo
ubidefeo approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, also the camelCase conversion in the JavaScript

@murilopolese murilopolese merged commit 801d7b1 into development Apr 16, 2024
1 check passed
@murilopolese murilopolese deleted the bugfix/saving branch April 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murilopolese @ubidefeo