Skip to content

fix mac binary not placed in a top level directory #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix mac binary not placed in a top level directory #16

merged 1 commit into from
Jul 22, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 18, 2022

This PR fixes the mac binary not being placed in a top level directory as the other binaries.
Before:

$ tar -tvf imgtool_1.8.0-arduino.1_macOS_64bit.tar.gz
-rwxr-xr-x runner/staff 8570880 2022-05-31 12:03 imgtool
-rw-r--r-- runner/staff   11527 2022-05-31 12:01 LICENSE.txt

After:

$ tar -tvf imgtool_1.8.0-arduino.2-rc2_macOS_64bit.tar.gz
drwxr-xr-x runner/staff      0 2022-07-18 11:04 imgtool_macOS_64bit/
-rwxr-xr-x runner/staff 8576528 2022-07-18 11:04 imgtool_macOS_64bit/imgtool
-rw-r--r-- runner/staff   11527 2022-07-18 11:04 imgtool_macOS_64bit/LICENSE.txt

@umbynos umbynos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jul 18, 2022
@umbynos umbynos requested a review from per1234 July 18, 2022 09:29
@umbynos umbynos self-assigned this Jul 18, 2022
per1234
per1234 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Umberto!

I like that the tar command is more simple now. I always get confused about the function of the -C flag in these repackaging steps.

@umbynos umbynos merged commit 86aff82 into main Jul 22, 2022
@umbynos umbynos deleted the umbynos/fix-mac-folder branch July 22, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbynos @per1234