Skip to content

Modbus Tutorial [MKC-756] #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Dec 2, 2022
Merged

Modbus Tutorial [MKC-756] #618

merged 26 commits into from
Dec 2, 2022

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

  • Outline for a Modbus Tutorial for the learn page.

Contribution Guidelines

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 28, 2022 •
edited
Loading

✅ docs-content deploy preview ready

@Hannes7eicher Hannes7eicher changed the title Modbus Tutorial Modbus Tutorial [MKC-756] Nov 23, 2022
@Hannes7eicher
Expanding content
305dfcb 
- max devices
- Cyclic Redundancy Check
- Byte and word ordering
- adding sources
@Hannes7eicher Hannes7eicher self-assigned this Nov 23, 2022
@Hannes7eicher Hannes7eicher marked this pull request as ready for review November 29, 2022 14:16
karlsoderby
karlsoderby requested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Hannes7eicher . I have added a few things that I believe could improve the structure of the article (should only take a few minutes to apply)!

@Hannes7eicher Hannes7eicher merged commit 540b1b9 into main Dec 2, 2022
@Hannes7eicher Hannes7eicher deleted the Modbus-Tutorial branch December 2, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marqdevx marqdevx marqdevx left review comments

@TaddyHC TaddyHC TaddyHC left review comments

@karlsoderby karlsoderby karlsoderby approved these changes

Assignees

@Hannes7eicher Hannes7eicher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hannes7eicher @marqdevx @karlsoderby @TaddyHC