Skip to content

fix: try fetch the sketch by path if not in the cache #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: try fetch the sketch by path if not in the cache #2010

merged 1 commit into from
Apr 17, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Apr 11, 2023 •
edited
Loading

Motivation

The sketch cache might be empty when trying to generate the secrets included in the main sketch file from the secrets property.

Closes #1999

Change description

Other information

Please follow the steps from #1999 to reproduce and verify the defect.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 11, 2023
@kittaakos kittaakos self-assigned this Apr 11, 2023
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Apr 13, 2023
fix: try fetch the sketch by path if not in the cache
a925183 
The sketch cache might be empty, when trying to generate
the secrets include in the main sketch file from the
`secrets` property.

Closes #1999

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos requested review from AlbyIanna and per1234 April 13, 2023 11:54
per1234
per1234 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to reproduce #1999 (thanks for the nice instructions!) using the build from main.

I am not able to reproduce it using the build from this PR.

Thanks Akos!

@kittaakos kittaakos merged commit 54f210d into main Apr 17, 2023
@kittaakos kittaakos deleted the #1999 branch April 17, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@kittaakos kittaakos

Labels
topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @per1234