Skip to content

ATL-653: Added error handling for core/lib install #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

kittaakos
Copy link
Contributor

From now on, we toast an error message and update the Arduino output channel if the platform/lib installation has failed for whatever reason.

I tested the changeset with the following 3rd party cores:

In-action:

screencast.2021-03-10.13-19-03.mp4

Before this change: there was no indication of the installation failure.

Signed-off-by: Akos Kitta [email protected]

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and it's a very nice improvement. Thanks Akos!

Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good

@ubidefeo
Copy link

🚀

@kittaakos kittaakos merged commit eadc993 into main Mar 12, 2021
@kittaakos kittaakos deleted the atl-653--handle-core-install-error-gracefully branch March 12, 2021 08:35
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants