Skip to content

fix: aligned Add File... behavior with IDE 1.x #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix: aligned Add File... behavior with IDE 1.x #1805

merged 1 commit into from
Jan 11, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

As asked for in #284, IDE2 can now add source files to the sketch folder root. Other files go into the data folder in the sketch folder root.

Change description

  • code files will be copied to the sketch folder root
  • other files go under the data folder in the sketch folder root
  • after adding code files to the sketch, new files are expected to open in an editor.
284.mp4

Other information

Closes #284

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

 - code files will be copied to sketch folder root
 - other files go under the `data` folder in the sketch folder root

Closes #284

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 6, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 January 6, 2023 13:43
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 197cea2 into main Jan 11, 2023
@kittaakos kittaakos deleted the #284 branch January 11, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to add existing files to a sketch
3 participants