Force notarization process to take place configuring Gon zip output #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, it looks like the So, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to force the notarization process to take place, we need to ask
gonto produce a.zipfile as output.As explained here #578 / #578 (comment) the
gon.config.hcl"zip" section is not mandatory di per se', but not having an "output" section at all will not start the notarization submission process for the binary.For our release process the generated
.zipfile has no use, as we repackage the signed binary thatgonreplaces in-place. The.zipis functional for the notary service submission onlyThanks to @zmoog for patiently explaining the whole process to me countless times 🙇♂️