[skip changelog] Fix Windows integration tests #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/fix-windows-integration-test
branch
6 times, most recently
from
77e4b10 to
93cd3f7
Compare
silvanocerza
force-pushed
the
scerza/fix-windows-integration-test
branch
from
93cd3f7 to
6005d5b
Compare
per1234
requested changes
Sep 7, 2021
Co-authored-by: per1234 <[email protected]>
per1234
approved these changes
Sep 7, 2021
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Enhances the integration tests for Windows to make them work with path that contain spaces.
Integration test can't run on Windows if the user has a space in its name, thus having paths with spaces.
Integration test can now run on Windows correctly also if the user has a path in its name.
titled accordingly?
None.
This brings it in line with
arduino-lintintegration tests:https://github.com/arduino/arduino-lint/blob/cafb51656543665766930a77a698c8b72ae829a9/tests/test_all.py#L262-L303
See how to contribute