Skip to content

Enhanced search logic of board listall, core search and lib search #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances an existing feature.

  • What is the current behavior?

board listall, core search and lib search all use fuzzy search logic to find matching results, this is often unreliable and might either return few results or too many depending on the query string.

  • What is the new behavior?

Fuzzy search logic has been removed in favor of the same logic used by board search, that has been taken from the library search dialog of the Java IDE with some improvements to handle unicode accents and other diatrics.

This way all searchable commands share the same logic and are more reliable.

This also affects the gRPC interface.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza requested a review from a team March 15, 2021 11:30
@silvanocerza silvanocerza self-assigned this Mar 15, 2021
@silvanocerza silvanocerza force-pushed the scerza/fuzzy-search-purge branch from d4191b0 to f3bc6c6 Compare March 15, 2021 11:34
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the IDE+CLI PR combo and it does what I expect
Thanks

@silvanocerza silvanocerza merged commit 414ab00 into master Mar 16, 2021
@silvanocerza silvanocerza deleted the scerza/fuzzy-search-purge branch March 16, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants