Skip to content

Add overwrite option to zip and git lib install for gRPC interface #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances two gRPC interface functions

  • What is the current behavior?

The gRPC interface fails if a zip and git library is already installed.
The temporary directory used to extract the zip archive is not cleaned after installation.

  • What is the new behavior?

An Overwrite flag can now be set to specify what to do when a library with the same name is installed.
The temporary directory used to extract the zip archive is now cleaned after installation.

The CLI will always overwrite the installed library if it exists.

No breaking changes.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza requested a review from a team March 8, 2021 16:15
@silvanocerza silvanocerza self-assigned this Mar 8, 2021
@silvanocerza silvanocerza merged commit 5704138 into master Mar 12, 2021
@silvanocerza silvanocerza deleted the scerza/fix-grpc-lib-install branch March 12, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants