Skip to content

Add flag to skip libraries dependencies installation to gRPC LibraryInstall function #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

silvanocerza
Copy link
Contributor

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Changes gRPC LibraryInstall function behaviour.

  • What is the current behavior?

LibraryInstall gRPC function doesn't install any library's dependencies.

  • What is the new behavior?

LibraryInstall gRPC function install every dependencies of the library being installed, a new flag noDeps has been added to skip the installation of depencies.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza force-pushed the scerza/lib-install-deps branch from 638e3bc to ead7e11 Compare February 24, 2021 10:38
@kittaakos
Copy link
Contributor

It works locally. Thank you, @silvanocerza 👍

@silvanocerza silvanocerza merged commit b8c9e89 into master Feb 24, 2021
@silvanocerza silvanocerza deleted the scerza/lib-install-deps branch February 24, 2021 17:05
silvanocerza added a commit that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants