Make archive validation error messages friendlier #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems I should've run the tests locally. I'll fix everything later |
|
@cmaglie @silvanocerza sorry for pinging you, but I could not find any information who to tag in PR and I think this PR adds useful changes. Please let me know if I need to change something. Thanks :) |
|
hey @ubergesundheit |
silvanocerza
approved these changes
Feb 23, 2021
ubergesundheit
commented
Feb 23, 2021
|
Merged! Thanks for the contribution, looking forward to future ones. :) |
silvanocerza
pushed a commit
that referenced
this pull request
Feb 25, 2021
* Make archive validation error messages friendlier * change behaviour a little + fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)User experience improvement
What is the current behavior?
Trying to install packages with
core install <fqdn>is not helpful when:Index file has incorrect size for a package file
Index file has no checksum for a package file
This PR improves the errors printed when the package file contains incorrect values
titled accordingly?
no
Tested with index file https://raw.githubusercontent.com/sensebox/senseBoxMCU-core/2feebd752e3b86e5b71bd2c4addfd3188f349885/package_sensebox_index.json containing a wrong size and no checksum for the latest package.
See how to contribute