Skip to content

Add multiple libraries installation when using --git-url or --zip-path flags #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances an existing command.

  • What is the current behavior?

When calling lib install with the --git-url or --zip-path flags only one library at a time can be installed, subsequent arguments are ignored.

# This would install only WiFi101 library
arduino-cli lib install --git-url https://github.com/arduino-libraries/WiFi101.git https://github.com/arduino-libraries/ArduinoBLE.git
# This would install only ArduinoBLE library
arduino-cli lib install --zip-path /path/to/ArduinoBLE.zip /path/to/WiFi101.zip
  • What is the new behavior?

Calling lib install with --git-url or --zip-path flags will install all libraries specified.

# This will install only WiFi101 and ArduinoBLE libraries
arduino-cli lib install --git-url https://github.com/arduino-libraries/WiFi101.git https://github.com/arduino-libraries/ArduinoBLE.git
# This will do the same
arduino-cli lib install --zip-path /path/to/ArduinoBLE.zip /path/to/WiFi101.zip

No.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza merged commit 7e55f9e into master Jan 22, 2021
@silvanocerza silvanocerza deleted the scerza/multiple-git-zip-lib-install branch January 22, 2021 08:46
@ubidefeo
Copy link

Just realised an issue with installing from zip file:
the directory structure is lost on decompressing.
@silvanocerza : REGRESSION 🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants