Skip to content

[skip changelog] Update UPGRADING.md with new breaking changes #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Dec 7, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Docs update.

  • What is the current behavior?

Not applicable.

  • What is the new behavior?

Updated the docs/UPGRADING.md file with instructions on how to handle certain breaking changes.

No.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza added the topic: documentation Related to documentation for the project label Dec 7, 2020
@silvanocerza silvanocerza requested review from per1234 and rsora December 7, 2020 10:07
@silvanocerza silvanocerza self-assigned this Dec 7, 2020
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor rewording suggestions.

@silvanocerza
Copy link
Contributor Author

Thanks @per1234, committed your suggestions. 👍

@silvanocerza silvanocerza force-pushed the scerza/upgrading-breaking-changes branch from 102726d to a197f29 Compare December 7, 2020 10:40
@silvanocerza silvanocerza merged commit cb5bdba into master Dec 7, 2020
@silvanocerza silvanocerza deleted the scerza/upgrading-breaking-changes branch December 7, 2020 11:17
silvanocerza added a commit that referenced this pull request Dec 7, 2020
* [skip changelog] Update UPGRADING.md with new breaking changes

* [skip changelog] Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

Co-authored-by: per1234 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants