Skip to content

Fix core search command not searching through package terms #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Fixes core search command.

  • What is the current behavior?

core search command doesn't search in a Platform's Package name, maintaner or website fields.
arduino-cli core search retro --additional-urls https://www.retrokits.com/rk002/arduino/package_retrokits_index.json doesn't find any core.

arduino-cli core search rk --additional-urls https://www.retrokits.com/rk002/arduino/package_retrokits_index.json finds the expected Retrokit core.

  • What is the new behavior?

core search command now searches in a Platform's Package name, maintaner or website fields.
Now both arduino-cli core search retro --additional-urls https://www.retrokits.com/rk002/arduino/package_retrokits_index.json and arduino-cli core search rk --additional-urls https://www.retrokits.com/rk002/arduino/package_retrokits_index.json find the expected Retrokit core.

  • Does this PR introduce a breaking change?

No.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza merged commit ba13ab4 into master Oct 12, 2020
@silvanocerza silvanocerza deleted the scerza/core-search branch October 12, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants