Provide irq safe implementation of RingBuffer #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative way to fix arduino#580 without restoring the buggy RingBuffer implementation from API
matthijskooijman
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
Code also looks good to me.
I wonder: Is this class something that should live in -API? I can imagine that this code is moved to API, and then individual cores make available a "sync.h" that -API can use to get platform-specific "synchronized" behaviour. As an added bonus, this would mean that synchronized can become a nice and portable way to disable interrupts (though I wonder if synchronized is the perfect name, but I guess it's modeled after Java, right?).
|
Memory usage change @ a110c0b
Click for full report table
|
|
Yes, it's modeled over Java and could have a more embedd-ish name if we decide to port it to -API 🙂 . |
Well, you could just require that a core that uses -API supplies a working
Agreeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative way to fix #580 without restoring the buggy RingBuffer implementation from API