Added POST to HttpClient #2107
Closed
Added POST to HttpClient #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added POST to HttpClient and also the ability to set a header (for API Keys) for GET and POST.
| addParameter("--header"); | ||
| addParameter(header); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I would remove setHeader and use addHeader(name, value) or just addHeader(header). A function with add in the name implies an accumulation, and also the ability to call it more than once. Since curl actually requires that you pass multiple --headers if you want to set more than one, having addHeader(header) makes more sense (to me, at least)
|
Closed by #2170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added POST to HttpClient and also the ability to set a header (for API
Keys) for GET and POST.