Support async custom completion closures #782
Open
+123
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg
force-pushed
the
555-async-custom-completion
branch
from
9916bb6 to
9a298ff
Compare
|
@natecook1000 This PR should be simpler to review than #764, so you might want to get this out of the way first. Thanks for reviewing / merging everything. |
Signed-off-by: Ross Goldberg <[email protected]>
|
@natecook1000 Added a multi-shell custom completion test for async custom completion handlers. Thanks for reviewing. |
natecook1000
approved these changes
May 22, 2025
|
@swift-ci Please test |
Signed-off-by: Ross Goldberg <[email protected]>
|
@natecook1000 I pushed an attempt to fix the Linux build issues. I didn't get any build or test issues on macOS 15.5, but I don't know how to run the Linux tests myself, or how to make the macOS tests mimic the Linux tests. I assume that the Linux tests have stricter concurrency checking enabled than the macOS & Windows tests do. Maybe they should be changed to be as strict as the Linux tests. Should I open an issue for that? Does one already exist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support async custom completion closures.
Resolve #555
Checklist