Skip to content

Prefer let for private configurations #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Prefer let for private configurations #617

merged 1 commit into from
Feb 28, 2024

Conversation

Coeur
Copy link
Contributor

@Coeur Coeur commented Feb 28, 2024

Prefer let for private configurations.
Otherwise, we may think that the configuration is mutable, which is not really sendable friendly.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@rauhul
Copy link
Contributor

rauhul commented Feb 28, 2024

@swift-ci please test

@natecook1000
Copy link
Member

Makes sense, thanks @Coeur!

@natecook1000 natecook1000 merged commit 1c8215f into apple:main Feb 28, 2024
@Coeur Coeur deleted the coeur/configuration branch February 28, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants