Skip to content

WASI: Fix Platform.exit's infinite recursion #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

kkebo
Copy link
Contributor

@kkebo kkebo commented Nov 13, 2022

This issue was introduced by #504.

When the target platform is WASI, Platform.exit causes infinite recursion because it calls itself.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@kkebo kkebo changed the title WASI: Fix Platform.exit WASI: Fix Platform.exit's infinite recursion Nov 13, 2022
@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000
Copy link
Member

Thanks, @KKK669!

@natecook1000 natecook1000 merged commit 208594a into apple:main Nov 14, 2022
@kkebo kkebo deleted the patch-1 branch March 22, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants