Skip to content

ArgumentParser: repair the build after #504 #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

compnerd
Copy link
Collaborator

There are references to functions from the Windows SDK rather than the C library for the console handling. Explicitly import the necessary types and functions from the WinSDK module so that Windows can build once more with the changes to sequester the platform specific code.

There are references to functions from the Windows SDK rather than the C
library for the console handling.  Explicitly import the necessary types
and functions from the WinSDK module so that Windows can build once more
with the changes to sequester the platform specific code.
@compnerd
Copy link
Collaborator Author

CC: @natecook1000 @rauhul

@compnerd
Copy link
Collaborator Author

@swift-ci please test

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies — looks like I missed an import WinSDK when moving things over. Working on getting a better testing situation in place to prevent things like this in the future.

@natecook1000 natecook1000 merged commit b99e170 into apple:main Oct 12, 2022
@compnerd compnerd deleted the unsequester branch October 12, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants