Skip to content

[SPARK-36035][PYTHON] Adjust test_astype, test_neg for old pandas versions #33250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

xinrong-meng
Copy link
Member

@xinrong-meng xinrong-meng commented Jul 7, 2021

What changes were proposed in this pull request?

Adjust test_astype, test_neg for old pandas versions.

Why are the changes needed?

There are issues in old pandas versions that fail tests in pandas API on Spark. We ought to adjust test_astype and test_neg for old pandas versions.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit tests. Please refer to #33272 for test results with pandas 1.0.1.

@xinrong-meng xinrong-meng changed the title [SPARK-36035][PYTHON] Make test_astype work with all pandas versions in pandas API on Spark [WIP][SPARK-36035][PYTHON] Adjust test_astype, test_neg for old pandas versions Jul 7, 2021
@SparkQA
Copy link

SparkQA commented Jul 7, 2021

Test build #140768 has finished for PR 33250 at commit 89ed506.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 7, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45280/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45280/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Test build #140818 has finished for PR 33250 at commit 1d0b30f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45329/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45329/

@xinrong-meng xinrong-meng changed the title [WIP][SPARK-36035][PYTHON] Adjust test_astype, test_neg for old pandas versions [SPARK-36035][PYTHON] Adjust test_astype, test_neg for old pandas versions Jul 9, 2021
@xinrong-meng xinrong-meng marked this pull request as ready for review July 9, 2021 02:13
@xinrong-meng
Copy link
Member Author

CC @ueshin @HyukjinKwon @itholic

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.2.

HyukjinKwon pushed a commit that referenced this pull request Jul 9, 2021
… versions

### What changes were proposed in this pull request?
Adjust `test_astype`, `test_neg`  for old pandas versions.

### Why are the changes needed?
There are issues in old pandas versions that fail tests in pandas API on Spark. We ought to adjust `test_astype` and `test_neg` for old pandas versions.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Unit tests. Please refer to #33272 for test results with pandas 1.0.1.

Closes #33250 from xinrong-databricks/SPARK-36035.

Authored-by: Xinrong Meng <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 698c4ec)
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants