-
Notifications
You must be signed in to change notification settings - Fork 28.5k
[SPARK-20706][SPARK-SHELL] Spark-shell not overriding method/variable definition #19879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OK, so another back-port to fix the 2.11 REPL, which should be resolved in 2.12 anyway? |
Test build #4003 has finished for PR 19879 at commit
|
This one has a "Major" priority; but otherwise yes, it should be resolved in Scala 2.12 version. |
By the way, are these contributions valuable, or should the focus be 2.12? |
Yes, I think it's reasonable to pull these fixes forward to patch medium-sized problems. We don't have 2.12 support fully working yet, even, so punting the solution to 2.12 means punting to 3.0, probably, and that's still ~6 months off. Meanwhile 2.3 is imminent. |
Fixed the style check problems of the documentation comments. Unfortunately I did not find a way to make Jenkins re-run the tests. |
Jenkins add to whitelist |
Test build #4004 has finished for PR 19879 at commit
|
Test build #84493 has finished for PR 19879 at commit
|
Merged to master |
What changes were proposed in this pull request?
SPARK-20706: Spark-shell not overriding method/variable definition
This is a Scala repl bug ( SI-9740 ), was fixed in version 2.11.9 ( see the original PR )
How was this patch tested?
Added a new test case in
ReplSuite
.