Skip to content

doc(architecture): update the ordering of vertical and horizontal headers in the statement #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vaishnavyogesh
Copy link

The line here seems to be incorrect since according to the table vertical headers denote LoggerConfig Level while horizontal ones denote LogEvent Level.

This MR updates the ordering to correctly explain the table beneath it.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@vy
Copy link
Member

vy commented May 8, 2025

@vaishnavyogesh, thanks so much for taking time review these and submit a correction. Unfortunately, main is substantially behind 2.x in terms of, among other things, documentation. It would be really helpful if you can port architecture.adoc from 2.x to main instead. Please make sure to verify your changes with ./mvnw site as as explained here.

@vy vy closed this May 8, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants