Skip to content

Migrate log4j-jakarta-smtp to JUnit 5 #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

AlbaHerrerias
Copy link
Contributor

Hello 👋

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in log4j-jakarta-smtp to JUnit5.

Thank you!

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@AlbaHerrerias AlbaHerrerias reopened this Oct 3, 2024
@vy vy self-assigned this Oct 3, 2024
@vy vy added the tests Pull requests or issues related to tests label Oct 3, 2024
@vy vy added this to the 2.25.0 milestone Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@vy vy merged commit f90dee8 into apache:2.x Oct 3, 2024
11 checks passed
@ppkarwasz ppkarwasz mentioned this pull request Nov 4, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests or issues related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants