MINOR: Fix null exception in coordinator log #10250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ableegoldman PTAL. |
ableegoldman
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Oh man, that's a stupid bug. Thanks for catching this -- we should also cherrypick this to 2.6, 2.7, & 2.8 (cc @vvcephei)
|
One unrelated test failure which is known to be flaky: |
|
@chia7712 do you want to merge this? We should also cherrypick it all the way back to 2.6 |
Sure. will merge and backport this patch. |
chia7712
pushed a commit
that referenced
this pull request
Mar 3, 2021
Reviewers: A. Sophie Blee-Goldman <[email protected]>, Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Mar 3, 2021
Reviewers: A. Sophie Blee-Goldman <[email protected]>, Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Mar 3, 2021
Reviewers: A. Sophie Blee-Goldman <[email protected]>, Chia-Ping Tsai <[email protected]>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Mar 3, 2021
* apache-github/trunk: KAFKA-12400: Upgrade jetty to fix CVE-2020-27223 MINOR: Fix null exception in coordinator log (apache#10250) y KAFKA-12375: don't reuse thread.id until a thread has fully shut down (apache#10215) KAFKA-12177: apply log start offset retention before time and size based retention (apache#10216) KAFKA-12369; Implement `ListTransactions` API (apache#10206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
Found that the
fatalExceptionis always null when callinglog.info("xxx", fatalException), maybe we should first assign a value to it.Summary of testing strategy (including rationale)
Test locally.
from
to
Committer Checklist (excluded from commit message)