-
Notifications
You must be signed in to change notification settings - Fork 109
refactor: collect dataframe as stream in __repr__
#1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…to repr-without-adding-limit
Hi @timsaucer , could you help to trigger CI and also review the proposed change? Thank you! |
…ious stream of batches. Also refactor _repr_html_.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It took me a while to parse through the logic of the get_batches
. I think it's worth adding some documentation within the file to explain why we are doing this so that future maintainers can understand the necessity of doing it this way.
Thank you for the PR!
Thank you for the reviewing! A new iteration is pushed to add code comments. |
Which issue does this PR close?
Closes #1014.
Rationale for this change
The root cause for #1014 is
_repr_
appends a limit clause and causes EXPLAIN not the top plan.What changes are included in this PR?
This change refactors
_repr_
to collect the dataframe as a stream.Before the change,
After the change
Are there any user-facing changes?
No. Bugfix only.