-
Notifications
You must be signed in to change notification settings - Fork 109
File issue against Polymer's closure plugin to support more jsdoc cases #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
tbosch
added a commit
to tbosch/tsickle
that referenced
this issue
Aug 1, 2017
when using a call expression. E.g. ``` Polymer({behaviors: [(Polymer as any).NeonAnimationRunnerBehavior]) ``` This type cast was never emitted in non transformer mode due to microsoft/TypeScript#9873. This is a temporary workaround, the real fix is to change the Polymer Closure plugin (see angular#529).
tbosch
added a commit
to tbosch/tsickle
that referenced
this issue
Aug 1, 2017
when using a call expression. E.g. ``` Polymer({behaviors: [(Polymer as any).NeonAnimationRunnerBehavior]) ``` This type cast was never emitted in non transformer mode due to microsoft/TypeScript#9873. This is a temporary workaround, the real fix is to change the Polymer Closure plugin (see angular#529).
tbosch
added a commit
to tbosch/tsickle
that referenced
this issue
Aug 1, 2017
when using a call expression. E.g. ``` Polymer({behaviors: [(Polymer as any).NeonAnimationRunnerBehavior]) ``` This type cast was never emitted in non transformer mode due to microsoft/TypeScript#9873. This is a temporary workaround, the real fix is to change the Polymer Closure plugin (see angular#529).
tbosch
added a commit
to tbosch/tsickle
that referenced
this issue
Aug 1, 2017
when using a call expression. E.g. ``` Polymer({behaviors: [(Polymer as any).NeonAnimationRunnerBehavior]) ``` This type cast was never emitted in non transformer mode due to microsoft/TypeScript#9873. This is a temporary workaround, the real fix is to change the Polymer Closure plugin (see angular#529).
tbosch
added a commit
that referenced
this issue
Aug 1, 2017
when using a call expression. E.g. ``` Polymer({behaviors: [(Polymer as any).NeonAnimationRunnerBehavior]) ``` This type cast was never emitted in non transformer mode due to microsoft/TypeScript#9873. This is a temporary workaround, the real fix is to change the Polymer Closure plugin (see #529).
tbosch
added a commit
to tbosch/tsickle
that referenced
this issue
Aug 4, 2017
in transformer mode. Closes angular#529
tbosch
added a commit
to tbosch/tsickle
that referenced
this issue
Aug 4, 2017
in transformer mode. Closes angular#529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
E.g. the transformer version of tsickle emits this code:
Given:
Emitted Closure JS code:
This leads to the error
ERROR - Behavior declarations must be annotated with @polymerBehavior.
. Looking at the code in Closure, this id because the check looks at the nearest jsdoc comment, which is now/** @type {?} */
.The text was updated successfully, but these errors were encountered: