Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

test(@angular-devkit/core): add missing parameter in angular-workspace.json #871

Merged
merged 1 commit into from
May 10, 2018
Merged

test(@angular-devkit/core): add missing parameter in angular-workspace.json #871

merged 1 commit into from
May 10, 2018

Conversation

nweldev
Copy link
Contributor

@nweldev nweldev commented May 9, 2018

In a6767dc, a defaultProject was added to workspaceJson in workspace_spec, which hasn't been
synced with tests/@angular_devkit/workspace/angular-workspace.json as expected. This was breaking
the related tests with more than one project, like in #739.

…e.json

In a6767dc, a defaultProject was added to workspaceJson in workspace_spec, which hasn't been
synced with tests/@angular_devkit/workspace/angular-workspace.json as expected. This was breaking
the related tests with more than one project, like in #739.
@nweldev
Copy link
Contributor Author

nweldev commented May 9, 2018

My bad, I missed all the customWorkspaceJson behaviours, so I fixed my tests in #789 better following the ones in a6767dc and this doesn't seems to be relevant anymore.

But I still would have a question about this (poke @filipesilva): is the comment about keeping the workspaceJson in sync with the json file still relevant if we can override it when we need ? If so, why ?

Keeping this PR open in order to discuss this and do the according updates.

@filipesilva
Copy link
Contributor

@noelmace I don't follow, what comment are you referring to?

@nweldev
Copy link
Contributor Author

nweldev commented May 9, 2018

@filipesilva
Copy link
Contributor

It should be kept in sync so another test (the one that tests the schema itself) is testing the same thing.

@filipesilva filipesilva merged commit b2cecd0 into angular:master May 10, 2018
@nweldev
Copy link
Contributor Author

nweldev commented May 10, 2018

Thanks a lot for your response. Let me know if you think I should change this json file in #872 then.

@nweldev nweldev deleted the fix-default-project-tests branch May 10, 2018 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants