This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@schematics/angular): update lint tools and rules for Angular 5 #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelyzer 4 is required for Angular 5.
This was referenced Nov 14, 2017
|
Commit log mentions the following: The following commit has a scope that does not exist:
3817aa2 fix(lint): update lint rules for codelyzer 4.0 and tslint 5.8
The following commit has a scope that does not exist:
9a0ec81 fix(lint): update lint tools for Angular 5
2 commits were found invalid...May be - would it be ok to have scope with 'build(aio)' (or something similar , based on git logs) ? Either way - would be nice to have this commit 'amend'ed and checked in. cc @cyrilletuzi |
cyrilletuzi
changed the title
codelyzer 4 is required for Angular 5. Some rules are removed as they are deprecated. tslint is also updated to 5.8.
|
Commit fd9ff3c is ok, I don't know why the last one popped up. And I think I messed up all my git history while trying to fix this. So I hope you guys can just pick up the good one. |
|
Seems like the build has failed again ! The following commit has an unknown type:
2a4783b Merge branch 'patch-4' of https://github.com/cyrilletuzi/devkit into patch-4
The following commit has a scope that does not exist:
3817aa2 fix(lint): update lint rules for codelyzer 4.0 and tslint 5.8
The following commit has a scope that does not exist:
9a0ec81 fix(lint): update lint tools for Angular 5
3 commits were found invalid...Looking at the git history - we can try something like - "feat(@schematics/angular)" or "fix(@schematics/angular)"Eg: 2017-10-25 11:41 Alex Rickabaugh o feat(@schematics/angular): update Angular version to 5.0.0cc @cyrilletuzi |
|
Guess - the HEAD of branch needs to be reset , and push -f again to remove this error in the log . Anyway would be good to have this. |
|
Closing, as duplicate #257 has been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codelyzer 4 is required for Angular 5 and some rules have been removed or deprecated in last versions of codelyzer and tslint.
Fixes angular/angular-cli#8324
@hansl @filipesilva