Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Allow discard tag when tagging function returns null #663

Closed
wants to merge 3 commits into from
Closed

Allow discard tag when tagging function returns null #663

wants to merge 3 commits into from

Conversation

alexcrown
Copy link
Contributor

Issue #485

@dimirc
Copy link
Contributor

dimirc commented Feb 15, 2015

LGTM

@dimirc
Copy link
Contributor

dimirc commented Feb 16, 2015

@alexcrown can you squash it to one commit?

@dimirc dimirc added this to the 0.9.9 milestone Feb 17, 2015
@LeleDev
Copy link

LeleDev commented Feb 17, 2015

Eagerly awaiting this to be merged

@dimirc dimirc added the tagging label Feb 18, 2015
@dimirc dimirc mentioned this pull request Feb 18, 2015
Merged
@dimirc
Copy link
Contributor

dimirc commented Feb 18, 2015

Rebased and Merged with #678

Thanks @alexcrown!

@dimirc dimirc closed this Feb 18, 2015
@LeleDev LeleDev mentioned this pull request Mar 19, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
tagging
Projects
None yet
Milestone
0.9.9
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcrown @dimirc @LeleDev