feat(Header & Footer): Add header & footer to the dropdown list. #1930

felixmosh · 2017-03-04T14:13:24Z

This feature allows to add header & footer to the dropdowns for each of the default templates.

Jefiozie · 2017-03-07T07:01:19Z

HI @felixmosh
Thanks for submitting this PR, looks like it will help resolve #1323 but before I can review this issue could you clean up the PR, you committed the dist directory and that is not correct. Also I believe a rebase is needed for the last changes.

Thanks looking forward on the review.

felixmosh · 2017-03-07T07:15:54Z

Done.

Jefiozie · 2017-03-09T18:28:16Z

src/common.css

-  left: 0px !important;
-  top: 0px !important;
+  left: 0 !important;
+  top: 0 !important;


Any specific reason why you changed the 0px to 0?

Convention wise, in css if you have 0px it should be 0.

Is the important needed?

I don`t know it was there before me :]

Jefiozie · 2017-03-09T18:31:29Z

src/common.css

 }

 .select2-result-single {
  padding-left: 0;
 }

-.select2-locked > .select2-search-choice-close{
-  display:none;


Could you fix all the spacing in this file?

Jefiozie · 2017-03-09T18:32:47Z

src/selectize/choices.tpl.html

@@ -1,5 +1,4 @@
-<div ng-show="$select.open" class="ui-select-choices ui-select-dropdown selectize-dropdown"


Could you explain why you removed all the classes from this div?

I`ve moved the dropdown classes and functionality to here https://github.com/angular-ui/ui-select/pull/1930/files/fdae8530b84f3426b3b411da2cf840248a09155a#diff-55a8341ed55143ae563b5f1e54237ca8R13

missed that one.

Jefiozie · 2017-03-09T18:34:21Z

test/select.spec.js

@@ -1,7 +1,7 @@
 'use strict';

-describe('ui-select tests', function() {


Could you fix the spacing in this file?

Jefiozie

See my comments 😄

Jefiozie · 2017-03-09T18:36:40Z

Second could you have a look at the wiki this is from a PR before. Maybe you can update it when this PR is merged.

felixmosh · 2017-03-09T18:52:44Z

The wiki is up to date to the current implementation :).
I`ve added additional example how to use it in each of the templates.

ahules · 2017-03-13T14:33:16Z

How we can use header/footer now? I mean what URL we must add to bower.json?

Jefiozie · 2017-03-13T19:03:27Z

@ahules Do you mean when this will be release so that you can use it with bower?

ahules · 2017-03-14T08:45:56Z

@Jefiozie yes, now I use TechNaturally/ui-select#feat-header-footer-bower. But that realisation of header/footer triggers click twice.
Maybe you can create some branch named "experimental" or smth. :)

Jefiozie · 2017-03-14T09:12:16Z

This will be released in the newer version of this repo. For now i'm not making any experimental branches. As i need to maintain that branch also and it is hard enough to maintain the repo on it own.
If need you can use the code as committed here.

Hope you understand.

ahules · 2017-03-14T09:18:47Z

@Jefiozie, Can you help? I will create fork and merge this commit manually?

Jefiozie · 2017-03-14T12:00:11Z

I don't have the time to help you having a hard time to maintaining this repo.
I hope to update the lib by the end of this month so then you can use the official library for the functionality.

Jefiozie · 2017-03-16T06:52:29Z

Hi @felixmosh Could you resolve the conflict? (don't know why this is suddenly here) afte this i will merge the PR. Thanks for your help.

felixmosh · 2017-03-16T09:40:29Z

Done

cyrilchapon · 2017-04-13T10:13:45Z

This breaks 100% width and ul bullet inside ui-select-choices on my application.

See

before (0.19.6)

after (0.19.7)

felixmosh · 2017-04-22T08:12:42Z

@Jefiozie why this PR was removed?

Jefiozie · 2017-04-23T15:55:18Z

There where two main reasons.

The angular injection was not correct (I had to address that to you sorry for that)
Second , for some reason the complete layout was corrupt. Still need to have a look why this happend.

felixmosh · 2017-04-23T16:46:55Z

@Jefiozie, I've fixed that already, I will create a new PR.
Any other design issues that you know of, except ul bullets and the width?

felixmosh · 2017-04-23T18:18:34Z

Fresh PR #1982

felixmosh mentioned this pull request Mar 4, 2017

Feature - header & footer #1323

Closed

Jefiozie assigned felixmosh Mar 7, 2017

Jefiozie added needs: rebasing needs: work labels Mar 7, 2017

felixmosh force-pushed the master branch 2 times, most recently from 502340a to fdae853 Compare March 7, 2017 07:15

Jefiozie self-requested a review March 7, 2017 07:17

Jefiozie unassigned felixmosh Mar 7, 2017

Jefiozie reviewed Mar 9, 2017

View reviewed changes

Jefiozie suggested changes Mar 9, 2017

View reviewed changes

Jefiozie added this to the v0.19.6 milestone Mar 9, 2017

Jefiozie added needs: docs and removed needs: rebasing labels Mar 9, 2017

felixmosh force-pushed the master branch from 576bfb9 to d49dba1 Compare March 9, 2017 18:50

Jefiozie approved these changes Mar 9, 2017

View reviewed changes

Jefiozie removed needs: docs needs: work labels Mar 9, 2017

felixmosh added 2 commits March 16, 2017 09:13

feat(Header & Footer): Add header & footer to the dropdown list.

f65bad1

Fix spacing

de2b276

felixmosh force-pushed the master branch from d49dba1 to de2b276 Compare March 16, 2017 07:13

Jefiozie merged commit 47883ed into angular-ui:master Mar 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Header & Footer): Add header & footer to the dropdown list. #1930

feat(Header & Footer): Add header & footer to the dropdown list. #1930

felixmosh commented Mar 4, 2017

Jefiozie commented Mar 7, 2017

felixmosh commented Mar 7, 2017

Jefiozie Mar 9, 2017

felixmosh Mar 9, 2017

Jefiozie Mar 9, 2017

felixmosh Mar 9, 2017 •

edited

Loading

Jefiozie Mar 9, 2017

felixmosh Mar 9, 2017

Jefiozie Mar 9, 2017

felixmosh Mar 9, 2017

Jefiozie Mar 9, 2017

Jefiozie Mar 9, 2017 •

edited

Loading

felixmosh Mar 9, 2017

Jefiozie left a comment

Jefiozie commented Mar 9, 2017

felixmosh commented Mar 9, 2017

ahules commented Mar 13, 2017

Jefiozie commented Mar 13, 2017

ahules commented Mar 14, 2017

Jefiozie commented Mar 14, 2017

ahules commented Mar 14, 2017

Jefiozie commented Mar 14, 2017

Jefiozie commented Mar 16, 2017

felixmosh commented Mar 16, 2017

cyrilchapon commented Apr 13, 2017

felixmosh commented Apr 22, 2017

Jefiozie commented Apr 23, 2017

felixmosh commented Apr 23, 2017 •

edited

Loading

felixmosh commented Apr 23, 2017

		@@ -1,5 +1,4 @@
		<div ng-show="$select.open" class="ui-select-choices ui-select-dropdown selectize-dropdown"

		@@ -1,7 +1,7 @@
		'use strict';

		describe('ui-select tests', function() {

feat(Header & Footer): Add header & footer to the dropdown list. #1930

feat(Header & Footer): Add header & footer to the dropdown list. #1930

Conversation

felixmosh commented Mar 4, 2017

Jefiozie commented Mar 7, 2017

felixmosh commented Mar 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

felixmosh Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jefiozie Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jefiozie left a comment

Choose a reason for hiding this comment

Jefiozie commented Mar 9, 2017

felixmosh commented Mar 9, 2017

ahules commented Mar 13, 2017

Jefiozie commented Mar 13, 2017

ahules commented Mar 14, 2017

Jefiozie commented Mar 14, 2017

ahules commented Mar 14, 2017

Jefiozie commented Mar 14, 2017

Jefiozie commented Mar 16, 2017

felixmosh commented Mar 16, 2017

cyrilchapon commented Apr 13, 2017

felixmosh commented Apr 22, 2017

Jefiozie commented Apr 23, 2017

felixmosh commented Apr 23, 2017 • edited Loading

felixmosh commented Apr 23, 2017

felixmosh Mar 9, 2017 •

edited

Loading

Jefiozie Mar 9, 2017 •

edited

Loading

felixmosh commented Apr 23, 2017 •

edited

Loading