This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Wrong input width calculated #1906
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search input width is currently calculated by subtracting 10 pixels from it's second parent width. But it should be the same, as the drop-down button width.
ghost
mentioned this pull request
|
Thanks for the PR, can you check why the tests are failing. |
|
HI @easyest , I have merged my PR could you rebase to the master? |
|
I would be glad to do that, but I do not use git at all. This PR was done by a simple edit in the web form :) |
|
okay, i just saw that this is a duplicated issue. So closing it down as the other has a PR #1874 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search input width is currently calculated by subtracting 10 pixels from it's second parent width. But it should be the same, as the drop-down button width.