This repository was archived by the owner on Oct 2, 2019. It is now read-only.
docs(*) update examples and automate build #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
|
|
||
| body { | ||
| opacity: 1; |
There was a problem hiding this comment.
Spacing is a bit inconsistent in this file - I see some 4 space indentations, and some 2 in places too. I'd recommend 2, but it's up to you.
|
A lot of good work here - just my minor comments, but otherwise LGTM |
user378230
force-pushed
the
docs/automate-update
branch
4 times, most recently
from
ff6fb38 to
ff06d88
Compare
- Converts previous example pages to invidual html partials which are wrapped in standard header and footer as part of a docs build process - Updates all examples to angular v1.5 making use of controllerAs syntax - Standardises the look and feel across examples - Creates dedicated github pages page (docs/index.html) which has links to all examples - Adds an "edit in plunkr" button to launch the example in a plunkr session - Automates the deployment to github pages using travis ci whenever the master branch is built. - General tidy up of README and index docs Closes #112
user378230
force-pushed
the
docs/automate-update
branch
from
ff06d88 to
511ed98
Compare
This was referenced Apr 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update to docs and examples
End result http://angular-ui.github.io/ui-select
Closes #112
The
gulpfileanddeploy-docs.shprobably need some work.Feedback welcome! 😄
Once its been reviewed I'll switch travis to publish on tags only.