This repository was archived by the owner on May 29, 2019. It is now read-only.
Expand $transition API a bit #933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some work on #911 and it seemed like these changes would have been
useful for it.
It turns out that they aren't really needed, but I thought it wouldn't hurt to
see if anyone thought they were useful/worth keeping.
There are a couple of tests added for the new functionality, which includes:
functions)
or toggle classes -- but add by default)
Anyways, just throwing these up there in case someone thinks they're useful, but if
not, as I've said I don't think they're really needed to fix #911 anyways. Cheers