Skip to content

Address aggressive truncation in Scope panel #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

dbassett17
Copy link
Contributor

@andrewdavey

At some point in the last few months an update to Chrome has made the extension start to truncate anything in the Scope panel that's larger than the panel. I'm not really sure what this change was and after spending a few hours looking for it I found nothing obvious in the Chrome changelogs.

I was able to fix this issue by adding position: relative to the top level span elements which effectively just ignores the wrapping elements truncation rules. The ellipsis still appears on top of the carrot but it's a minor issue compared to the data not showing up at all. I tried a bunch of other solutions and couldn't get anything to work quite as well as the position: relative so if anyone else has any suggestions I'd be happy to look into them

I think it used to cut off the record at the end of the line instead of wrapping it around to the next line which could be slightly concerning for larger records so if you think that's an issue I can look into ways to fix it.

I ran the test page and didn't see any regressions in my testing

Example

Before After
image image

@nbperry
Copy link

nbperry commented Nov 11, 2019

@andrewdavey can you take a quick look at this? This issue has been becoming more and more annoying and this seems to fix it locally. This should also fix the issue in https://github.com/mattzeunert/immutable-object-formatter-extension which then @mattzeunert could probably do a new release to the chrome store.

@andrewdavey andrewdavey merged commit 52a1559 into andrewdavey:master Nov 11, 2019
@andrewdavey
Copy link
Owner

Thanks for the contribution!

Merged and published v0.1.5 to npm

jdeniau pushed a commit to immutable-js/immutable-devtools that referenced this pull request May 18, 2025
…fix-truncation

Address aggressive truncation in Scope panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants