-
Notifications
You must be signed in to change notification settings - Fork 89
Add Target Encoder to Components #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 218 220 +2
Lines 14433 14582 +149
=========================================
+ Hits 14426 14575 +149
Misses 7 7
Continue to review full report at Codecov.
|
738dd3e
to
008f495
Compare
evalml/pipelines/components/transformers/encoders/target_encoder.py
Outdated
Show resolved
Hide resolved
df27616
to
23bcdeb
Compare
9c7b851
to
3c58563
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 Looks good! Thanks for hunting down that weird bug hehe. I have a suggestion for how to guard against that bug without taking the extreme measure of resetting the index at the pipeline level. But maybe that is something we should consider in the future! Custom indices have shot us in the foot so many times lol.
fix #1390
Adding target encoder to components. Perf test results are here
Docs are here
[UPDATE]
On Friday, 11/6, we decided to add additional perf tests for
TE
(discussion in the quip doc above).Things to test:
The perf test doc contains these 3 tests, ordered from 3, 1, 2.