Skip to content

fix: Expose State types from react-stately in react-aria-components #8157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2025
Merged

fix: Expose State types from react-stately in react-aria-components #8157

merged 4 commits into from
May 19, 2025
+4 −2

Conversation

lukpsaxo
Copy link
Contributor

Closes #8156

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

N/A

🧢 Your Project:

Saxo Bank

@yihuiliao
Copy link
Member

The team seems fine with this. If you wouldn't mind, since we're allowing it for TableState, we might as well expand this and export the state types for the other components. You can find them by just checking which components have an exported StateContext. Thanks!

@lukpsaxo
Copy link
Contributor Author

lukpsaxo commented May 2, 2025

I will do. will be monday due to other work.

@lukpsaxo lukpsaxo changed the title fix: Expose TableState from react-stately in react-aria-components fix: Expose State types from react-stately in react-aria-components May 6, 2025
@lukpsaxo
Copy link
Contributor Author

Is this ok now?

yihuiliao
yihuiliao approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, appreciate your patience with this while the team was busy with release. Now that's done I'll try to get some eyes on it. Thanks for making those updates!

reidbarber
reidbarber approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@reidbarber reidbarber enabled auto-merge May 19, 2025 19:16
@reidbarber reidbarber added this pull request to the merge queue May 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2025
@yihuiliao yihuiliao added this pull request to the merge queue May 19, 2025
Merged via the queue into adobe:main with commit 30c8693 May 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose TableState from react-stately in react-aria-components
3 participants
@lukpsaxo @yihuiliao @reidbarber