TableView overlay auto tab stop Firefox fix #3520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
LFDanLu
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Seem to work well in FF, Chrome, and Safari, TalkBack, and VO. Since this tabindex=-1 is on the ScrollView it shouldn't interfere with the "restore focus back to the collection" code that useVirtualizer/useSelectableCollection has.
One interesting note is that this adds an additional "focus" target that TalkBack can access now because of the new tabindex but I think this is a minor point IMO
snowystinger
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Seems fine, didn't notice any issues with the focus changes we recently made to collections. Cases such as deleting everything in ActionGroup stories.
BTW, we should link this in the wiki https://bugzilla.mozilla.org/show_bug.cgi?id=616594
dannify
changed the title
dannify
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Found during testing, but pre-existing issue. In Firefox, an element with overflow auto or scroll is a tab stop. This caused an empty table to be tabbed too twice.
✅ Pull Request Checklist:
📝 Test Instructions:
In FireFox, go to any TableView story with no content (renderEmptyState, isLoading, etc.) and tab into the TableView. It should only stop once on the table body during keyboard tab navigation.
🧢 Your Project:
RSP