Skip to content

small errors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coelner opened this issue Jul 12, 2018 · 3 comments
Closed

small errors #9

coelner opened this issue Jul 12, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@coelner
Copy link

coelner commented Jul 12, 2018

  1. Do not call Wire.begin(). It is up to the system to set up the bus not the library. (With this call you reset the bus and all other devices get stuck uninitialized) Multiply Wire.begin(int sda, int scl) call from different libraries esp8266/Arduino#2607
  2. wiki: The operation mode 100 is missing, copy-paste-error
@SV-Zanshin SV-Zanshin self-assigned this Jul 12, 2018
@SV-Zanshin SV-Zanshin added the bug Something isn't working label Jul 12, 2018
@SV-Zanshin
Copy link
Collaborator

The Wire.h library entry doesn't actually do anything but set internal variables and call twi_init(). The bug you refer to is specific to the esp826 and calling Wire.begin(SDA,SCL) with 2 Parameters for Software i2c, which the INA library doesn't do, it calls Wire.begin() with no Parameters.

If this does actually cause Problems on the ESP2866 then the following could be added to the library:

#ifndef __ESP3288__
  Wire.begin()
#endif

(I have to see what the actual library Definition is for the Esplora

@SV-Zanshin
Copy link
Collaborator

Corrected the wiki page https://github.com/SV-Zanshin/INA/wiki/setMode()

SV-Zanshin pushed a commit that referenced this issue Jul 12, 2018
@SV-Zanshin SV-Zanshin changed the title small erros small errors Jul 12, 2018
@SV-Zanshin
Copy link
Collaborator

Added the
#ifndef ESP8266
Wire.begin()
#endif

I don't have an Esplora to test this with, so if you could check to see if this resolves the issue that would be great. If the error is still present, then we can re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants