do nothing in set_name() #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-salim
reviewed
Aug 23, 2019
src/libstd/sys/vxworks/thread.rs
Outdated
| @@ -77,7 +77,7 @@ impl Thread { | |||
| } | |||
|
|
|||
| pub fn set_name(_name: &CStr) { | |||
| assert!(false, "FIXME: set_name"); | |||
| // do nothing | |||
There was a problem hiding this comment.
Improve comment:
// VxWorks does not provide a way to set the task name except at creation time
BaoshanPang
force-pushed
the
set_name_003
branch
from
4f07415 to
912feab
Compare
n-salim
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VxWorks doesn't support set thread's name after it has created, so make this function do nothing.
r? @n-salim
@n-salim
I am creating this PR again branch master_003 is because I want to create a seperate PR to upstream the code later. If I merge the code into branch master then the code would be part of last PR. I hope the PR for upstream this code would be faster in this way.