wasm2c: Support saturating-float-to-int #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Same caveats with --disable-* flags as #1679 apply. This was fairly trivial tho, it was basically a matter of copy-paste.) |
kripken
reviewed
Jun 28, 2021
| #define I32_TRUNC_SAT_S_F64(x) TRUNC_SAT_S(u32, s32, f64, -2147483649., INT32_MIN, >, 2147483648., INT32_MAX, x) | ||
| #define I64_TRUNC_SAT_S_F64(x) TRUNC_SAT_S(u64, s64, f64, (f64)INT64_MIN, INT64_MIN, >=, (f64)INT64_MAX, INT64_MAX, x) | ||
|
|
||
| #define TRUNC_SAT_U(ut, ft, max, smax, x) \ |
There was a problem hiding this comment.
what does s mean in smax? from the code it looks like the integer / non-float maximum, but I'm not able to guess at what s is an abbreviation of...
There was a problem hiding this comment.
saturated was what we were thinking at the time.
There was a problem hiding this comment.
Oh, I see.. yes, that makes sense!
kripken
approved these changes
Jun 29, 2021
| #define I32_TRUNC_SAT_S_F64(x) TRUNC_SAT_S(u32, s32, f64, -2147483649., INT32_MIN, >, 2147483648., INT32_MAX, x) | ||
| #define I64_TRUNC_SAT_S_F64(x) TRUNC_SAT_S(u64, s64, f64, (f64)INT64_MIN, INT64_MIN, >=, (f64)INT64_MAX, INT64_MAX, x) | ||
|
|
||
| #define TRUNC_SAT_U(ut, ft, max, smax, x) \ |
There was a problem hiding this comment.
Oh, I see.. yes, that makes sense!
SoniEx2
added a commit
to SoniEx2/wasm2kotlin
that referenced
this pull request
Feb 22, 2022
sbc100
pushed a commit
that referenced
this pull request
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.